<html>
<head><meta charset="utf-8"><title>weekly meeting 2019-03-28 #54818 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html">weekly meeting 2019-03-28 #54818</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="161949020"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161949020" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161949020">(Mar 28 2019 at 12:57)</a>:</h4>
<p>Hi <span class="user-group-mention" data-user-group-id="897">@T-compiler/meeting</span> ; our weekly meeting, held in this topic area, will be started in about 63 minutes.</p>



<a name="161949081"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161949081" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161949081">(Mar 28 2019 at 12:58)</a>:</h4>
<p>In the meantime I will be doing weekly triage in a <a href="#narrow/stream/131828-t-compiler/topic/pre-meeting.20triage.202019-03-28.20.2354818/near/161948966" title="#narrow/stream/131828-t-compiler/topic/pre-meeting.20triage.202019-03-28.20.2354818/near/161948966">parallel topic</a></p>



<a name="161949157"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161949157" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161949157">(Mar 28 2019 at 12:59)</a>:</h4>
<p>The <a href="https://github.com/rust-lang/compiler-team/blob/master/about/triage-meeting.md#working-group-check-in" target="_blank" title="https://github.com/rust-lang/compiler-team/blob/master/about/triage-meeting.md#working-group-check-in">schedule for WG-checkin</a> says that this week we might be hearing from wg-parallel-rustc and wg-pgo</p>



<a name="161949185"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161949185" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161949185">(Mar 28 2019 at 12:59)</a>:</h4>
<p><span class="user-mention" data-user-id="116466">@Zoxc</span> or <span class="user-mention" data-user-id="124287">@mw</span> : is one of you prepared to present for wg-parallel-rustc in about 90 minutes or so?</p>



<a name="161949268"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161949268" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161949268">(Mar 28 2019 at 13:00)</a>:</h4>
<p>and <span class="user-mention" data-user-id="124287">@mw</span> , you are listed as the context for wg-pgo, so maybe you'll be doing both presentations? Or maybe you plan to delegate to <span class="user-mention" data-user-id="116466">@Zoxc</span> ?</p>



<a name="161949311"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161949311" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161949311">(Mar 28 2019 at 13:00)</a>:</h4>
<p>(Just let me know so that I block off time accordingly. I know it is short notice; i should have sent out a note on Tuesday, but I forgot.)</p>



<a name="161950024"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950024" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950024">(Mar 28 2019 at 13:10)</a>:</h4>
<p>I can do a little update on PGO</p>



<a name="161950059"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950059" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950059">(Mar 28 2019 at 13:11)</a>:</h4>
<p>I'm feeling a bit disorganized around wg-parallel-rustc</p>



<a name="161950137"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950137" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950137">(Mar 28 2019 at 13:12)</a>:</h4>
<p>okay. Do you think that <span class="user-mention" data-user-id="116466">@Zoxc</span> would have more to say? Or should we not bother with a wg-parallel-rustc check-in this week then?</p>



<a name="161950200"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950200" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950200">(Mar 28 2019 at 13:13)</a>:</h4>
<p>well, if <span class="user-mention" data-user-id="116466">@Zoxc</span> would like to give an update, I'd certainly be interested. But if not, it's better to do it another time</p>



<a name="161950218"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950218" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950218">(Mar 28 2019 at 13:13)</a>:</h4>
<p>PSA to T-compiler -- if you r+ a PR someone else is assigned to, please r? yourself as well</p>



<a name="161950319"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950319" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950319">(Mar 28 2019 at 13:14)</a>:</h4>
<blockquote>
<p>PSA to T-compiler -- if you r+ a PR someone else is assigned to, please r? yourself as well</p>
</blockquote>
<p>fair enough. (for context for others: this is regarding what I did on PR <a href="https://github.com/rust-lang/rust/issues/59468" target="_blank" title="https://github.com/rust-lang/rust/issues/59468">#59468</a>)</p>



<a name="161950345"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950345" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950345">(Mar 28 2019 at 13:14)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span>  yes but it happens a lot ;)</p>



<a name="161950370"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950370" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950370">(Mar 28 2019 at 13:15)</a>:</h4>
<p>maybe the bot should do it</p>



<a name="161950393"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950393" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950393">(Mar 28 2019 at 13:15)</a>:</h4>
<p>its an interesting policy question, whether that should be automatic or not</p>



<a name="161950398"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950398" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950398">(Mar 28 2019 at 13:15)</a>:</h4>
<p>yeah that would be nice; ^ <span class="user-mention" data-user-id="121055">@Pietro Albini</span></p>



<a name="161950408"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950408" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950408">(Mar 28 2019 at 13:15)</a>:</h4>
<p>if one steals review action, it certainly seems like one should take on the burden of assignment as well.</p>



<a name="161950492"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950492" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950492">(Mar 28 2019 at 13:16)</a>:</h4>
<p>I do <code>r? @Centril @bors r+ rollup</code> often these days ;)</p>



<a name="161950547"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950547" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950547">(Mar 28 2019 at 13:17)</a>:</h4>
<p>if/when you decide that's something you want open an issue on <a href="https://github.com/rust-lang/infra-team" target="_blank" title="https://github.com/rust-lang/infra-team">https://github.com/rust-lang/infra-team</a></p>



<a name="161950677"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950677" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950677">(Mar 28 2019 at 13:19)</a>:</h4>
<p>okay, I'll set up an emoji poll for (the benefit for those on mobile where normal poll feature does not work.)</p>



<a name="161950785"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950785" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950785">(Mar 28 2019 at 13:20)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span>  I'll create a GH issue tagged with T-compiler, T-infra, T-release, T-libs, T-lang and rfcbot merge it</p>



<a name="161950792"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950792" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950792">(Mar 28 2019 at 13:20)</a>:</h4>
<p>Should <code>@bors r+</code> cause bors to also <code>r? &lt;yourself&gt;</code>, which implies the issue is assigned to you? <span aria-label="thumbs up" class="emoji emoji-1f44d" role="img" title="thumbs up">:thumbs_up:</span> or <span aria-label="thumbs down" class="emoji emoji-1f44e" role="img" title="thumbs down">:thumbs_down:</span> or <span aria-label="shrug" class="emoji emoji-1f937" role="img" title="shrug">:shrug:</span>  based on your immediate opinion ( <span aria-label="shrug" class="emoji emoji-1f937" role="img" title="shrug">:shrug:</span> is effectively "abstain").</p>



<a name="161950809"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950809" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950809">(Mar 28 2019 at 13:20)</a>:</h4>
<p>(since this is a matter for more than t-compiler)</p>



<a name="161950840"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950840" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950840">(Mar 28 2019 at 13:21)</a>:</h4>
<p>true. So we'll see how people react, but I'll try not to devote too much time to it since it is a cross-team-spanning concern.</p>



<a name="161950851"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161950851" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161950851">(Mar 28 2019 at 13:21)</a>:</h4>
<p>cool</p>



<a name="161951314"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161951314" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161951314">(Mar 28 2019 at 13:26)</a>:</h4>
<p><span aria-label="construction worker" class="emoji emoji-1f477" role="img" title="construction worker">:construction_worker:</span> seeking (or "sought") volunteer for  "Future-incompatible warnings should always print a warning, even if lints are allowed" <a href="https://github.com/rust-lang/rust/issues/34596" target="_blank" title="https://github.com/rust-lang/rust/issues/34596">#34596</a></p>



<a name="161951362"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161951362" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161951362">(Mar 28 2019 at 13:27)</a>:</h4>
<p>(to be clear, <span class="user-mention" data-user-id="126931">@centril</span> did say they would look at <a href="https://github.com/rust-lang/rust/issues/34596" target="_blank" title="https://github.com/rust-lang/rust/issues/34596">#34596</a>. But I'm just following a protocol here to increase visibility of the work item)</p>



<a name="161951933"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161951933" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161951933">(Mar 28 2019 at 13:32)</a>:</h4>
<p>That's accomplished by making them warnings and not lints</p>



<a name="161952045"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161952045" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161952045">(Mar 28 2019 at 13:33)</a>:</h4>
<p>And I personally would expect that silencing a lint that is warning me about deprecation will eventually lead to my code not compiling in a subsequent version... Of course that gets hairy with libs hiding these lint warnings from their downstreams</p>



<a name="161952122"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161952122" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161952122">(Mar 28 2019 at 13:34)</a>:</h4>
<p><span class="user-mention" data-user-id="119031">@Esteban Küber</span>  I think you should be able to <code>deny(...)</code> them so keeping them as lints makes sense</p>



<a name="161952145"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161952145" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161952145">(Mar 28 2019 at 13:34)</a>:</h4>
<p>rather, we should be able to designate lints as future-compat ones and assign a cap (e.g. "no more liberal than Warn")</p>



<a name="161952878"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161952878" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161952878">(Mar 28 2019 at 13:42)</a>:</h4>
<p>Fair point</p>



<a name="161952981"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161952981" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161952981">(Mar 28 2019 at 13:43)</a>:</h4>
<p>Disregard my digression, the implementing the suggested behavior isn't that much work and it is clearly a better situation than either of the current options</p>



<a name="161954489"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161954489" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161954489">(Mar 28 2019 at 13:58)</a>:</h4>
<p><span aria-label="alert" class="emoji emoji-1f6a8" role="img" title="alert">:alert:</span> Re: "beta 1.33 seems to break tarpaulin on multithreading" <a href="https://github.com/rust-lang/rust/issues/58104" target="_blank" title="https://github.com/rust-lang/rust/issues/58104">#58104</a> -- I'm planning to close this as non-actionable, as I suggested doing back when I nominated it four weeks ago.</p>



<a name="161954815"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161954815" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161954815">(Mar 28 2019 at 14:01)</a>:</h4>
<p>hi <span class="user-group-mention" data-user-group-id="897">@T-compiler/meeting</span></p>



<a name="161954909"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161954909" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161954909">(Mar 28 2019 at 14:02)</a>:</h4>
<p>I've been doing triage in the <a href="#narrow/stream/131828-t-compiler/topic/pre-meeting.20triage.202019-03-28.20.2354818/near/161948966" title="#narrow/stream/131828-t-compiler/topic/pre-meeting.20triage.202019-03-28.20.2354818/near/161948966">parallel topic</a></p>



<a name="161954956"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161954956" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161954956">(Mar 28 2019 at 14:02)</a>:</h4>
<p>I actually think it went better than much in week's past. Still didn't get through every P-high issue, but I got through a lot</p>



<a name="161955040"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955040" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955040">(Mar 28 2019 at 14:03)</a>:</h4>
<p>there were ten issues left, eight of them are assigned. so lets just collectively double-check the two that were unassigned</p>



<a name="161955061"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955061" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955061">(Mar 28 2019 at 14:03)</a>:</h4>
<p>first: "ripgrep fails to build with MUSL on Linux since the nightly release on 2019-03-15" <a href="https://github.com/rust-lang/rust/issues/59411" target="_blank" title="https://github.com/rust-lang/rust/issues/59411">#59411</a></p>



<a name="161955086"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955086" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955086">(Mar 28 2019 at 14:03)</a>:</h4>
<p>this is new, and I only assigned it P-high duing a triage pre-pass</p>



<a name="161955196"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955196" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955196">(Mar 28 2019 at 14:04)</a>:</h4>
<p>it also has a PR (<a href="https://github.com/rust-lang/rust/issues/59468" target="_blank" title="https://github.com/rust-lang/rust/issues/59468">#59468</a>). I guess I might try to assign it to the author  of the PR ... and if that fails, I'll assign it to myself</p>



<a name="161955306"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955306" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955306">(Mar 28 2019 at 14:05)</a>:</h4>
<p>second unassigned P-high issue: "Wrapping simd call results in compiler panic (nightly)" <a href="https://github.com/rust-lang/rust/issues/59469" target="_blank" title="https://github.com/rust-lang/rust/issues/59469">#59469</a></p>



<a name="161955397"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955397" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955397">(Mar 28 2019 at 14:06)</a>:</h4>
<p>this is also new</p>



<a name="161955405"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955405" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955405">(Mar 28 2019 at 14:06)</a>:</h4>
<p>(like, less than a day old)</p>



<a name="161955424"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955424" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955424">(Mar 28 2019 at 14:06)</a>:</h4>
<p>so I won't panic about assigning it to someone yet. But if someone <em>wants</em> to take it now, feel free.</p>



<a name="161955452"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955452" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955452">(Mar 28 2019 at 14:06)</a>:</h4>
<p>okay, that's all the P-high's I care to discuss.</p>



<a name="161955491"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955491" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955491">(Mar 28 2019 at 14:07)</a>:</h4>
<p>next, <a href="https://github.com/rust-lang/rust/issues?utf8=%E2%9C%93&amp;q=label%3Abeta-nominated+label%3AT-compiler" target="_blank" title="https://github.com/rust-lang/rust/issues?utf8=%E2%9C%93&amp;q=label%3Abeta-nominated+label%3AT-compiler">beta-noms marked T-compiler</a></p>



<a name="161955526"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955526" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955526">(Mar 28 2019 at 14:07)</a>:</h4>
<p>namely: "Fix fallout from <a href="https://github.com/rust-lang/rust/issues/57667" target="_blank" title="https://github.com/rust-lang/rust/issues/57667">#57667</a>" <a href="https://github.com/rust-lang/rust/issues/58021" target="_blank" title="https://github.com/rust-lang/rust/issues/58021">#58021</a></p>



<a name="161955541"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955541" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955541">(Mar 28 2019 at 14:07)</a>:</h4>
<p>not my favorite PR description ever. (the joke is that no description was given by PR author. I'll put one in.)</p>



<a name="161955603"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955603" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955603">(Mar 28 2019 at 14:08)</a>:</h4>
<p>(especially since github issue titles don't do the hyperlinks)</p>



<a name="161955862"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955862" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955862">(Mar 28 2019 at 14:10)</a>:</h4>
<p>there was some issue that I tried to reproduce last week but failed</p>



<a name="161955871"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955871" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955871">(Mar 28 2019 at 14:11)</a>:</h4>
<p>it was one of those "requesting volunteer" issues I thiink...</p>



<a name="161955895"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955895" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955895">(Mar 28 2019 at 14:11)</a>:</h4>
<blockquote>
<p>(especially since github issue titles don't do the hyperlinks)</p>
</blockquote>
<p>(give <a href="https://addons.mozilla.org/en-US/firefox/addon/refined-github-/" target="_blank" title="https://addons.mozilla.org/en-US/firefox/addon/refined-github-/">refined GitHub</a> a try)</p>



<a name="161955899"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955899" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955899">(Mar 28 2019 at 14:11)</a>:</h4>
<p>ah well no matter, I guess you took a look during pre-triage</p>



<a name="161955969"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161955969" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161955969">(Mar 28 2019 at 14:12)</a>:</h4>
<p>sorry for my silence, I was reviewing the comment thread on PR <a href="https://github.com/rust-lang/rust/issues/58021" target="_blank" title="https://github.com/rust-lang/rust/issues/58021">#58021</a></p>



<a name="161956025"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956025" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956025">(Mar 28 2019 at 14:12)</a>:</h4>
<p>but now I've managed to confuse myself</p>



<a name="161956036"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956036" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956036">(Mar 28 2019 at 14:12)</a>:</h4>
<p>since the comment thread prepared me for a really complicated PR</p>



<a name="161956055"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956055" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956055">(Mar 28 2019 at 14:13)</a>:</h4>
<p>but the actual diff that was settled on looks ... very simple?</p>



<a name="161956155"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956155" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956155">(Mar 28 2019 at 14:14)</a>:</h4>
<p>yea I think everyone realized that <code>Box</code> is more magical than everyone was aware of, and everything went well from there</p>



<a name="161956179"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956179" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956179">(Mar 28 2019 at 14:14)</a>:</h4>
<p>I guess <span class="user-mention" data-user-id="119009">@eddyb</span> even asked <span class="user-mention" data-user-id="116009">@nikomatsakis</span> and me to explain when box became magical enough to do this: <a href="https://github.com/rust-lang/rust/pull/58021#discussion_r265109175" target="_blank" title="https://github.com/rust-lang/rust/pull/58021#discussion_r265109175">https://github.com/rust-lang/rust/pull/58021#discussion_r265109175</a></p>



<a name="161956208"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956208" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956208">(Mar 28 2019 at 14:14)</a>:</h4>
<p>is there any chance that the point where box became "sufficiently magical" actually <em>postdates</em> the current beta?</p>



<a name="161956220"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956220" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956220">(Mar 28 2019 at 14:15)</a>:</h4>
<p>I think the probability of that is about 0.00001%</p>



<a name="161956265"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956265" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956265">(Mar 28 2019 at 14:15)</a>:</h4>
<blockquote>
<p>is there any chance that the point where box became "sufficiently magical" actually <em>postdates</em> the current beta?</p>
</blockquote>
<p>(because this would be the only reason I would see to not approve a beta backport here, I think)</p>



<a name="161956273"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956273" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956273">(Mar 28 2019 at 14:15)</a>:</h4>
<p>I would guess that this fell our from NLL</p>



<a name="161956292"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956292" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956292">(Mar 28 2019 at 14:15)</a>:</h4>
<p>We made a decision to stop artificially hobbling boxes in the analysis</p>



<a name="161956365"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956365" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956365">(Mar 28 2019 at 14:16)</a>:</h4>
<p>okay and the code in question is somewhere in libstd that has NLL enabled?</p>



<a name="161956379"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956379" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956379">(Mar 28 2019 at 14:16)</a>:</h4>
<p>that is my guess</p>



<a name="161956404"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956404" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956404">(Mar 28 2019 at 14:16)</a>:</h4>
<p>I'd also like to know what bugs were observed from the orginal mistake</p>



<a name="161956461"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956461" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956461">(Mar 28 2019 at 14:17)</a>:</h4>
<p>i.e. it certainly sounds like the code being fixed is doing a double-drop, right?</p>



<a name="161956469"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956469" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956469">(Mar 28 2019 at 14:17)</a>:</h4>
<p>(Why was there no regression test added  as part of this?)</p>



<a name="161956481"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956481" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956481">(Mar 28 2019 at 14:17)</a>:</h4>
<p><span aria-label="frown" class="emoji emoji-1f641" role="img" title="frown">:frown:</span></p>



<a name="161956485"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956485" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956485">(Mar 28 2019 at 14:17)</a>:</h4>
<p>That's what I understood from <span class="user-mention" data-user-id="119009">@eddyb</span>'s comment</p>



<a name="161956569"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956569" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956569">(Mar 28 2019 at 14:18)</a>:</h4>
<p>okay, well... what's the current beta schedule? When's the next beta being cut?</p>



<a name="161956570"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956570" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956570">(Mar 28 2019 at 14:18)</a>:</h4>
<blockquote>
<p>(Why was there no regression test added  as part of this?)</p>
</blockquote>
<p>oversight I guess</p>



<a name="161956656"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956656" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956656">(Mar 28 2019 at 14:19)</a>:</h4>
<p>because I would personally like to get the chance to write a regression test for this bug and just double check that against stable + beta + nightly</p>



<a name="161956684"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956684" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956684">(Mar 28 2019 at 14:19)</a>:</h4>
<p>and while I don't want to prevent this from getting into stable in a timely fashion as part of the natural train flow</p>



<a name="161956765"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956765" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956765">(Mar 28 2019 at 14:20)</a>:</h4>
<p>if the beta is being cut sometime <em>after</em> next week's T-compiler meeitng</p>



<a name="161956786"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956786" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956786">(Mar 28 2019 at 14:20)</a>:</h4>
<p>then I'd prefer to delay approval of beta-backporting this</p>



<a name="161956794"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956794" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956794">(Mar 28 2019 at 14:20)</a>:</h4>
<p>I guess that may be silly of me</p>



<a name="161956801"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956801" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956801">(Mar 28 2019 at 14:20)</a>:</h4>
<p>perhaps better to just go ahead and approve backport</p>



<a name="161956804"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956804" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956804">(Mar 28 2019 at 14:20)</a>:</h4>
<p>and do my investigation in parallel?</p>



<a name="161956827"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956827" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956827">(Mar 28 2019 at 14:20)</a>:</h4>
<p>Let me go ahead and put up an emoji poll</p>



<a name="161956861"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956861" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956861">(Mar 28 2019 at 14:21)</a>:</h4>
<p>Q: Should we beta-backport "Fix fallout from <a href="https://github.com/rust-lang/rust/issues/57667" target="_blank" title="https://github.com/rust-lang/rust/issues/57667">#57667</a>" <a href="https://github.com/rust-lang/rust/issues/58021" target="_blank" title="https://github.com/rust-lang/rust/issues/58021">#58021</a></p>



<a name="161956999"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161956999" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161956999">(Mar 28 2019 at 14:22)</a>:</h4>
<p>In other issues: We still have the long-standing "[do not merge] Measure performance impact of local interners" <a href="https://github.com/rust-lang/rust/issues/57214" target="_blank" title="https://github.com/rust-lang/rust/issues/57214">#57214</a> waiting on our team</p>



<a name="161957043"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957043" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957043">(Mar 28 2019 at 14:23)</a>:</h4>
<p>(SNL has a skit about a talk show where they always run out of time before they talk to their third guest... who is always the same character...)</p>



<a name="161957086"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957086" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957086">(Mar 28 2019 at 14:23)</a>:</h4>
<p>there has at least been discussion on the issue itself, that is good</p>



<a name="161957158"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957158" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957158">(Mar 28 2019 at 14:24)</a>:</h4>
<blockquote>
<p>In other issues: We still have the long-standing "[do not merge] Measure performance impact of local interners" <a href="https://github.com/rust-lang/rust/issues/57214" target="_blank" title="https://github.com/rust-lang/rust/issues/57214">#57214</a> waiting on our team</p>
</blockquote>
<p>maybe we should schedule a time to talk about this?</p>



<a name="161957166"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957166" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957166">(Mar 28 2019 at 14:24)</a>:</h4>
<p>or about memory usage in general</p>



<a name="161957167"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957167" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957167">(Mar 28 2019 at 14:24)</a>:</h4>
<p>and assign someone to lead and prep the discussion?</p>



<a name="161957181"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957181" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957181">(Mar 28 2019 at 14:24)</a>:</h4>
<p>yeah I mean it would be good to figure out what we are <em>blocked</em> on precisely</p>



<a name="161957191"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957191" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957191">(Mar 28 2019 at 14:25)</a>:</h4>
<p>my sense is that it's a bit of "uncertainty about how to proceed" more than anything</p>



<a name="161957243"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957243" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957243">(Mar 28 2019 at 14:25)</a>:</h4>
<p>I guess that the concerns <span class="user-mention" data-user-id="123586">@nagisa</span> raised were mostly kind of "memory usage is too high, let's not regress, even a bit"?</p>



<a name="161957245"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957245" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957245">(Mar 28 2019 at 14:25)</a>:</h4>
<p><span aria-label="construction worker" class="emoji emoji-1f477" role="img" title="construction worker">:construction_worker:</span> seeking volunteer to schedule and lead a meeting for T-compiler to discuss <a href="https://github.com/rust-lang/rust/issues/57214" target="_blank" title="https://github.com/rust-lang/rust/issues/57214">#57214</a>, and perhaps digress into related issues of how to address rustc memory usage.</p>



<a name="161957255"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957255" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957255">(Mar 28 2019 at 14:25)</a>:</h4>
<p>I have the feeling that everyone wants to do this but there's a vague fear of using too much memory</p>



<a name="161957319"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957319" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957319">(Mar 28 2019 at 14:26)</a>:</h4>
<p>and being so vague there's no actual way to overcome it</p>



<a name="161957332"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957332" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957332">(Mar 28 2019 at 14:26)</a>:</h4>
<p>I do really like <span class="user-mention" data-user-id="116466">@Zoxc</span> 's response there: lets identify simpler ways to keep ourselves under a memory budget.</p>



<a name="161957358"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957358" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957358">(Mar 28 2019 at 14:26)</a>:</h4>
<p>anyway, I'm happy the <del>issue</del> PR got some more visibility</p>



<a name="161957359"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957359" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957359">(Mar 28 2019 at 14:26)</a>:</h4>
<p>Right. So I see a few outcomes:</p>
<ul>
<li>Ignore this fear and move.</li>
<li>Try to get some data and decide the fear is unwarranted.</li>
<li>Independently, get serious about reducing memory usage.</li>
</ul>



<a name="161957419"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957419" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957419">(Mar 28 2019 at 14:27)</a>:</h4>
<p>so we have <a href="https://github.com/rust-lang/rust/issues?utf8=%E2%9C%93&amp;q=is%3Aopen%20label%3AT-compiler%20label%3AI-nominated%20" target="_blank" title="https://github.com/rust-lang/rust/issues?utf8=%E2%9C%93&amp;q=is%3Aopen%20label%3AT-compiler%20label%3AI-nominated%20">eight nominated T-compiler issues</a></p>



<a name="161957421"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957421" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957421">(Mar 28 2019 at 14:27)</a>:</h4>
<p>I agree with <span class="user-mention" data-user-id="116466">@Zoxc</span> as well -- I don't thik it's "fair" to "blame" this change for our high memory usage per se, but I also agree with <span class="user-mention" data-user-id="123586">@nagisa</span> that it is perhaps a problem worth attacking.</p>



<a name="161957433"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957433" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957433">(Mar 28 2019 at 14:27)</a>:</h4>
<p>/me will leave some comments</p>



<a name="161957464"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957464" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957464">(Mar 28 2019 at 14:28)</a>:</h4>
<p>I think based on <span class="user-mention" data-user-id="124287">@mw</span> 's earlier comments that we are only going to hear from one working-group today, not two</p>



<a name="161957514"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957514" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957514">(Mar 28 2019 at 14:28)</a>:</h4>
<p><a href="https://perf.rust-lang.org/compare.html?start=aeed63bf383e46bbaf932f4b555697ddb8328d89&amp;end=2eb7307a44bc76a18eeb0c4d2947492b2be4cbf2&amp;stat=max-rss" target="_blank" title="https://perf.rust-lang.org/compare.html?start=aeed63bf383e46bbaf932f4b555697ddb8328d89&amp;end=2eb7307a44bc76a18eeb0c4d2947492b2be4cbf2&amp;stat=max-rss">https://perf.rust-lang.org/compare.html?start=aeed63bf383e46bbaf932f4b555697ddb8328d89&amp;end=2eb7307a44bc76a18eeb0c4d2947492b2be4cbf2&amp;stat=max-rss</a></p>



<a name="161957536"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957536" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957536">(Mar 28 2019 at 14:28)</a>:</h4>
<p>this is data on the regression, right?</p>



<a name="161957571"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957571" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957571">(Mar 28 2019 at 14:28)</a>:</h4>
<p>yes, I'll give an update on PGO</p>



<a name="161957582"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957582" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957582">(Mar 28 2019 at 14:29)</a>:</h4>
<p>okay lets do that update now</p>



<a name="161957598"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957598" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957598">(Mar 28 2019 at 14:29)</a>:</h4>
<p>alright</p>



<a name="161957604"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957604" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957604">(Mar 28 2019 at 14:29)</a>:</h4>
<p>and then we'll spend the time afterthe update on nominated issues</p>



<a name="161957613"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957613" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957613">(Mar 28 2019 at 14:29)</a>:</h4>
<p>since that can balloon</p>



<a name="161957622"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957622" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957622">(Mar 28 2019 at 14:29)</a>:</h4>
<p>so PGO stands for "profile-guided optimization" and, in general, works first collection data about a programs typical execution</p>



<a name="161957632"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957632" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957632">(Mar 28 2019 at 14:29)</a>:</h4>
<p>(e.g. which branches it is likely to take)</p>



<a name="161957643"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957643" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957643">(Mar 28 2019 at 14:29)</a>:</h4>
<p>and then using that data to inform optimizations such as inlining, machine-code layout (for better i-cache behavior), register allocation, etc.</p>



<a name="161957696"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957696" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957696">(Mar 28 2019 at 14:30)</a>:</h4>
<p>it's often considered an important optimization</p>



<a name="161957742"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957742" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957742">(Mar 28 2019 at 14:30)</a>:</h4>
<p>there are different ways of collecting data about a program.</p>



<a name="161957749"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957749" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957749">(Mar 28 2019 at 14:30)</a>:</h4>
<p>one is to run the program inside a profiler, such as <code>perf</code>.</p>



<a name="161957760"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957760" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957760">(Mar 28 2019 at 14:30)</a>:</h4>
<p>another is to create an instrumented binary that has data collection built right into it.</p>



<a name="161957766"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957766" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957766">(Mar 28 2019 at 14:30)</a>:</h4>
<p>the latter usually provides more accurate data.</p>



<a name="161957778"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957778" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957778">(Mar 28 2019 at 14:30)</a>:</h4>
<p>LLVM supports both approaches and for the instrumented approach it support 3 (sic!) variations:</p>



<a name="161957791"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957791" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957791">(Mar 28 2019 at 14:30)</a>:</h4>
<ul>
<li>"Front-end level" instrumentation: Relies on the compiler front-end such as rustc or clang, to add instrumentation intrinsics to the LLVM IR</li>
</ul>



<a name="161957798"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957798" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957798">(Mar 28 2019 at 14:30)</a>:</h4>
<ul>
<li>"IR level" instrumentation: Uses the same LLVM IR intrinsics but they are added automatically by an LLVM pass</li>
</ul>



<a name="161957812"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957812" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957812">(Mar 28 2019 at 14:31)</a>:</h4>
<ul>
<li>GCOV instrumentation (used normally for code coverage, discouraged because it adds more overhead and is less accurate)</li>
</ul>



<a name="161957821"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957821" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957821">(Mar 28 2019 at 14:31)</a>:</h4>
<p><code>rustc</code> has experimental support for IR-level instrumentation, which is both the easiest to support (because LLVM does most of the work) and is also the more "modern" approach.</p>



<a name="161957840"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957840" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957840">(Mar 28 2019 at 14:31)</a>:</h4>
<p>I don't know if we ever want to support FE-level instrumentation or GCOV.</p>



<a name="161957855"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957855" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957855">(Mar 28 2019 at 14:31)</a>:</h4>
<p>so far, the work of this working group (of which I am the only member) has been to find out about the stuff described above</p>



<a name="161957861"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957861" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957861">(Mar 28 2019 at 14:31)</a>:</h4>
<p>how it all works (roughly) at the level of LLVM and compiler-rt</p>



<a name="161957873"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957873" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957873">(Mar 28 2019 at 14:32)</a>:</h4>
<p>and trying to get a non-trivial, mixed Rust/C++ code base (Firefox) to compile with PGO enabled.</p>



<a name="161957910"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957910" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957910">(Mar 28 2019 at 14:32)</a>:</h4>
<p>(what does clang do?)</p>



<a name="161957922"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957922" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957922">(Mar 28 2019 at 14:32)</a>:</h4>
<p>or are you getting to that...</p>



<a name="161957928"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957928" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957928">(Mar 28 2019 at 14:32)</a>:</h4>
<p>clang supports all of them</p>



<a name="161957966"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957966" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957966">(Mar 28 2019 at 14:32)</a>:</h4>
<p>the D-frontend for LLVM only supports front-end level, I think</p>



<a name="161957984"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957984" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957984">(Mar 28 2019 at 14:33)</a>:</h4>
<p>I was able to verify that instrumented code from Rust and from C++ can be linked together into a single binary</p>



<a name="161957998"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161957998" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161957998">(Mar 28 2019 at 14:33)</a>:</h4>
<p>and that running the binary generates profiling data that contains counts for both Rust and C++</p>



<a name="161958005"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958005" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958005">(Mar 28 2019 at 14:33)</a>:</h4>
<p>IFF both binaries are instrumented with the IR-level approach</p>



<a name="161958014"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958014" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958014">(Mar 28 2019 at 14:33)</a>:</h4>
<p>Mixing IR-level and FE-level instrumentation does not work, although they are both built on the same infrastructure in compiler-rt.</p>



<a name="161958021"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958021" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958021">(Mar 28 2019 at 14:33)</a>:</h4>
<p>that took me a few days to find out :P</p>



<a name="161958040"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958040" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958040">(Mar 28 2019 at 14:33)</a>:</h4>
<p>I have yet to work on verifying the PGO data actually gets used correctly and that it improves performance.</p>



<a name="161958054"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958054" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958054">(Mar 28 2019 at 14:33)</a>:</h4>
<p>There are also platform specific problems that are not yet resolved.</p>



<a name="161958105"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958105" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958105">(Mar 28 2019 at 14:34)</a>:</h4>
<p>E.g. instrumentation seems to crash Clang when it encounters a function using SEH on Windows, which is something that we might run into too.</p>



<a name="161958128"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958128" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958128">(Mar 28 2019 at 14:34)</a>:</h4>
<p>yeah, so this is where I am at right now</p>



<a name="161958156"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958156" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958156">(Mar 28 2019 at 14:34)</a>:</h4>
<p>it's nice that PGO subsumes "ordering files", it seems</p>



<a name="161958182"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958182" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958182">(Mar 28 2019 at 14:35)</a>:</h4>
<p>another optimization that affects code layout in binaries</p>



<a name="161958201"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958201" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958201">(Mar 28 2019 at 14:35)</a>:</h4>
<p>leading to better caching behavior</p>



<a name="161958214"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958214" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958214">(Mar 28 2019 at 14:35)</a>:</h4>
<p>LLVM's pgo should take care of that</p>



<a name="161958247"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958247" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958247">(Mar 28 2019 at 14:35)</a>:</h4>
<blockquote>
<p>E.g. instrumentation seems to crash Clang when it encounters a function using SEH on Windows, which is something that we might run into too.</p>
</blockquote>
<p>that <em>does</em> seem unfortunate, presumably an LLVM bug?</p>



<a name="161958310"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958310" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958310">(Mar 28 2019 at 14:36)</a>:</h4>
<p>bug or "not yet implemented" I guess</p>



<a name="161958318"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958318" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958318">(Mar 28 2019 at 14:36)</a>:</h4>
<p>It sounds like the plan, though, is still to do IR-level? This seems to fit reasonably well with the whole ThinLTO approach, no?</p>



<a name="161958364"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958364" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958364">(Mar 28 2019 at 14:36)</a>:</h4>
<p>fortunately we have someone looking into it who really knows windows well</p>



<a name="161958374"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958374" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958374">(Mar 28 2019 at 14:36)</a>:</h4>
<p>in other words, if you want max perf for a mixed Rust/C++-level thing, then we try to get all the sources to the level of LLVM IR, and then apply a combined pipeline for profiling, inlining, and optimizing them..?</p>



<a name="161958398"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958398" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958398">(Mar 28 2019 at 14:37)</a>:</h4>
<p>Or is that overly simplified :)</p>



<a name="161958403"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958403" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958403">(Mar 28 2019 at 14:37)</a>:</h4>
<p>yes, it should work together with THinLTO</p>



<a name="161958457"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958457" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958457">(Mar 28 2019 at 14:37)</a>:</h4>
<p>that's basically how it works, yes</p>



<a name="161958561"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958561" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958561">(Mar 28 2019 at 14:38)</a>:</h4>
<p>you could also do Rust and C++ separately though</p>



<a name="161958575"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958575" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958575">(Mar 28 2019 at 14:38)</a>:</h4>
<p>ThinLTO is orthogonal</p>



<a name="161958593"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958593" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958593">(Mar 28 2019 at 14:38)</a>:</h4>
<p>also cross-language LTO is orthogonal</p>



<a name="161958654"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958654" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958654">(Mar 28 2019 at 14:39)</a>:</h4>
<p>but like with cross lang LTO you better make sure that your Clang and Rust's LLVM match :)</p>



<a name="161958678"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958678" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958678">(Mar 28 2019 at 14:39)</a>:</h4>
<blockquote>
<p>ThinLTO is orthogonal</p>
</blockquote>
<p>in the sense that you could incorporate the pgo data when compiling the rust code on its own</p>



<a name="161958688"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958688" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958688">(Mar 28 2019 at 14:39)</a>:</h4>
<p>yes</p>



<a name="161958691"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958691" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958691">(Mar 28 2019 at 14:40)</a>:</h4>
<p>it seems like pgo would however be helpful to ThinLTO (to guide inlining decisions)</p>



<a name="161958752"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958752" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958752">(Mar 28 2019 at 14:40)</a>:</h4>
<p>yep</p>



<a name="161958763"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958763" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958763">(Mar 28 2019 at 14:40)</a>:</h4>
<p>and ThinLTO makes use of PGO data indeed</p>



<a name="161958830"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958830" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958830">(Mar 28 2019 at 14:41)</a>:</h4>
<p>so, that's pretty much my update</p>



<a name="161958851"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958851" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958851">(Mar 28 2019 at 14:41)</a>:</h4>
<p>questions?</p>



<a name="161958947"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958947" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958947">(Mar 28 2019 at 14:42)</a>:</h4>
<p>I'm trying to think</p>



<a name="161958949"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958949" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958949">(Mar 28 2019 at 14:42)</a>:</h4>
<p>it all makes sense of course</p>



<a name="161958982"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958982" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958982">(Mar 28 2019 at 14:42)</a>:</h4>
<p>we could use it, of course, to make the compiler itself faster too</p>



<a name="161958986"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958986" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958986">(Mar 28 2019 at 14:43)</a>:</h4>
<p>Maybe orthogonal Q: what is our current policy about when ThinLTO is enabled?</p>



<a name="161958994"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161958994" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161958994">(Mar 28 2019 at 14:43)</a>:</h4>
<p>I guess my question is -- what is your next step? and to what extent is this work (along with ThinLTO) going to be something that we can help projects beyond FF take advantage of?</p>



<a name="161959020"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959020" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959020">(Mar 28 2019 at 14:43)</a>:</h4>
<p>And maybe if you have any sense of how <em>much</em> work remains -- it's fine if it's too early to say.</p>



<a name="161959103"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959103" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959103">(Mar 28 2019 at 14:44)</a>:</h4>
<blockquote>
<p>what is your next step?</p>
</blockquote>
<p>verifying that rustc's version of LLVM uses the data correctly</p>



<a name="161959137"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959137" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959137">(Mar 28 2019 at 14:44)</a>:</h4>
<blockquote>
<p>to what extent is this work (along with ThinLTO) going to be something that we can help projects beyond FF take advantage of?</p>
</blockquote>
<p>Once it's stable, any project can use it to get better performance for their release builds</p>



<a name="161959167"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959167" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959167">(Mar 28 2019 at 14:45)</a>:</h4>
<p>PGO is very popular amoing game developers, usually</p>



<a name="161959197"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959197" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959197">(Mar 28 2019 at 14:45)</a>:</h4>
<p>but anywhere where you have the resources to set up some automation for this can take advantage</p>



<a name="161959282"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959282" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959282">(Mar 28 2019 at 14:46)</a>:</h4>
<p>it would be interesting to see this used with, for example, ripgrep</p>



<a name="161959291"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959291" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959291">(Mar 28 2019 at 14:46)</a>:</h4>
<p>which is performance sensitive</p>



<a name="161959304"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959304" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959304">(Mar 28 2019 at 14:46)</a>:</h4>
<p>yeah</p>



<a name="161959311"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959311" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959311">(Mar 28 2019 at 14:46)</a>:</h4>
<p>and you mentioned rustc, of course</p>



<a name="161959348"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959348" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959348">(Mar 28 2019 at 14:47)</a>:</h4>
<blockquote>
<p>Maybe orthogonal Q: what is our current policy about when ThinLTO is enabled?</p>
</blockquote>
<p>ThinLTO is the default for <code>cargo build --release</code></p>



<a name="161959363"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959363" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959363">(Mar 28 2019 at 14:47)</a>:</h4>
<p>iirc</p>



<a name="161959391"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959391" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959391">(Mar 28 2019 at 14:47)</a>:</h4>
<p>hmm</p>



<a name="161959413"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959413" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959413">(Mar 28 2019 at 14:47)</a>:</h4>
<p>oh, <em>cargo</em></p>



<a name="161959477"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959477" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959477">(Mar 28 2019 at 14:48)</a>:</h4>
<p>which may differ from the defaults of <code>rustc</code>, right?</p>



<a name="161959497"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959497" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959497">(Mar 28 2019 at 14:48)</a>:</h4>
<p>I need to keep that in mind when I benchmark in the future. <span aria-label="sad" class="emoji emoji-2639" role="img" title="sad">:sad:</span></p>



<a name="161959519"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959519" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959519">(Mar 28 2019 at 14:48)</a>:</h4>
<p>I think <code>rustc</code> uses it by default for opt-level &gt;= 2 and codegen-units &gt; 1</p>



<a name="161959528"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959528" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959528">(Mar 28 2019 at 14:48)</a>:</h4>
<p>right, the problem I saw</p>



<a name="161959536"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959536" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959536">(Mar 28 2019 at 14:48)</a>:</h4>
<p>was that it isn't enabled for codegen-units=1</p>



<a name="161959558"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959558" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959558">(Mar 28 2019 at 14:49)</a>:</h4>
<p>yes</p>



<a name="161959559"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959559" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959559">(Mar 28 2019 at 14:49)</a>:</h4>
<p>but you need codegen-units=1 to observe optimal performance in some cases</p>



<a name="161959584"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959584" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959584">(Mar 28 2019 at 14:49)</a>:</h4>
<p>this was what I was looking at: <a href="https://github.com/rust-lang/rust/issues/11084#issuecomment-475577073" target="_blank" title="https://github.com/rust-lang/rust/issues/11084#issuecomment-475577073">https://github.com/rust-lang/rust/issues/11084#issuecomment-475577073</a></p>



<a name="161959608"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959608" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959608">(Mar 28 2019 at 14:49)</a>:</h4>
<p>and also the comment immediately above it</p>



<a name="161959615"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959615" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959615">(Mar 28 2019 at 14:49)</a>:</h4>
<p>anyway I know this is not the problem of PGO</p>



<a name="161959682"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959682" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959682">(Mar 28 2019 at 14:50)</a>:</h4>
<p>it just reminded me that I was idly wondering about whether our defaults for <code>-C opt-level=3</code> are "good"</p>



<a name="161959724"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959724" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959724">(Mar 28 2019 at 14:50)</a>:</h4>
<p>yeah, the defaults won't give you  the best performance</p>



<a name="161959763"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959763" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959763">(Mar 28 2019 at 14:51)</a>:</h4>
<p>I guess I should probably look for pre-existing issues about the UX here</p>



<a name="161959789"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959789" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959789">(Mar 28 2019 at 14:51)</a>:</h4>
<p><em>anyway</em></p>



<a name="161959853"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959853" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959853">(Mar 28 2019 at 14:52)</a>:</h4>
<p><code>-Ccodegen-units</code> could be made to default to <code>1</code> if <code>-Copt-level=3</code>?</p>



<a name="161959902"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959902" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959902">(Mar 28 2019 at 14:52)</a>:</h4>
<p>That was something I was indeed musing about</p>



<a name="161959930"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959930" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959930">(Mar 28 2019 at 14:52)</a>:</h4>
<p>(and have it <em>still</em> default to lto=thin, I <em>think</em>, based on what I observed on that ticket I linked)</p>



<a name="161959957"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959957" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959957">(Mar 28 2019 at 14:53)</a>:</h4>
<p>well, there are two ways of doing THinLTO with rustc</p>



<a name="161959964"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959964" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959964">(Mar 28 2019 at 14:53)</a>:</h4>
<p>7 minutes left, and 7 <a href="https://github.com/rust-lang/rust/issues?utf8=%E2%9C%93&amp;q=is%3Aopen%20label%3AT-compiler%20label%3AI-nominated%20" target="_blank" title="https://github.com/rust-lang/rust/issues?utf8=%E2%9C%93&amp;q=is%3Aopen%20label%3AT-compiler%20label%3AI-nominated%20">nominated issues</a></p>



<a name="161959970"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959970" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959970">(Mar 28 2019 at 14:53)</a>:</h4>
<p>"local" and "crate-graph"</p>



<a name="161959985"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959985" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959985">(Mar 28 2019 at 14:53)</a>:</h4>
<blockquote>
<p>"local" and "crate-graph"</p>
</blockquote>
<p>oh I'm not familiar with this</p>



<a name="161959987"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161959987" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161959987">(Mar 28 2019 at 14:53)</a>:</h4>
<p>"local" makes no sense with 1 cgu...</p>



<a name="161960074"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960074" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960074">(Mar 28 2019 at 14:54)</a>:</h4>
<p>let me quickly run through the nominations</p>



<a name="161960078"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960078" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960078">(Mar 28 2019 at 14:54)</a>:</h4>
<p>anyway, let's discuss nominated issues</p>



<a name="161960081"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960081" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960081">(Mar 28 2019 at 14:54)</a>:</h4>
<p>make sure there are no fires</p>



<a name="161960111"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960111" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960111">(Mar 28 2019 at 14:54)</a>:</h4>
<p><span aria-label="construction worker" class="emoji emoji-1f477" role="img" title="construction worker">:construction_worker:</span> "Refactor rustc_codegen_ssa (part 2)" <a href="https://github.com/rust-lang/rust/issues/56636" target="_blank" title="https://github.com/rust-lang/rust/issues/56636">#56636</a> is crying out for a reviewer</p>



<a name="161960113"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960113" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960113">(Mar 28 2019 at 14:54)</a>:</h4>
<p>any volunteers?</p>



<a name="161960129"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960129" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960129">(Mar 28 2019 at 14:54)</a>:</h4>
<p>(<span class="user-mention" data-user-id="119009">@eddyb</span>  is assigned but I think we should hand it off to someone else)</p>



<a name="161960150"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960150" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960150">(Mar 28 2019 at 14:55)</a>:</h4>
<p>((if we're going to do that refactoring at all))</p>



<a name="161960171"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960171" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960171">(Mar 28 2019 at 14:55)</a>:</h4>
<p>It's blocked on <a href="https://github.com/rust-lang/rust/pull/58846" target="_blank" title="https://github.com/rust-lang/rust/pull/58846">https://github.com/rust-lang/rust/pull/58846</a></p>



<a name="161960178"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960178" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960178">(Mar 28 2019 at 14:55)</a>:</h4>
<p>I'll skip <a href="https://github.com/rust-lang/rust/issues/57214" target="_blank" title="https://github.com/rust-lang/rust/issues/57214">#57214</a> since we already discussed it</p>



<a name="161960203"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960203" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960203">(Mar 28 2019 at 14:55)</a>:</h4>
<blockquote>
<p>It's blocked on <a href="https://github.com/rust-lang/rust/pull/58846" target="_blank" title="https://github.com/rust-lang/rust/pull/58846">https://github.com/rust-lang/rust/pull/58846</a></p>
</blockquote>
<p>okay then ...</p>



<a name="161960268"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960268" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960268">(Mar 28 2019 at 14:56)</a>:</h4>
<p><span aria-label="construction worker" class="emoji emoji-1f477" role="img" title="construction worker">:construction_worker:</span> also seeking reviewer for "Misc refactorings to rustc_codegen_ssa" <a href="https://github.com/rust-lang/rust/issues/58846" target="_blank" title="https://github.com/rust-lang/rust/issues/58846">#58846</a></p>



<a name="161960269"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960269" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960269">(Mar 28 2019 at 14:56)</a>:</h4>
<p>(but that one could use a reviewer since eddyb hasn't done much here)</p>



<a name="161960340"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960340" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960340">(Mar 28 2019 at 14:56)</a>:</h4>
<p>"Rustc should use a variable other than RUST_LOG for env_logger." <a href="https://github.com/rust-lang/rust/issues/57985" target="_blank" title="https://github.com/rust-lang/rust/issues/57985">#57985</a> was accidentally still nominated; fixed now.</p>



<a name="161960402"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960402" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960402">(Mar 28 2019 at 14:57)</a>:</h4>
<p>next, "beta 1.33 seems to break tarpaulin on multithreading" <a href="https://github.com/rust-lang/rust/issues/58104" target="_blank" title="https://github.com/rust-lang/rust/issues/58104">#58104</a> : as announced in an <span aria-label="alert" class="emoji emoji-1f6a8" role="img" title="alert">:alert:</span> at start of meeting, I'm planning to close this as non-actionable if no-one speaks up</p>



<a name="161960430"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960430" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960430">(Mar 28 2019 at 14:57)</a>:</h4>
<p>next: "Implement "pipelined" rustc compilation (compiler side)" <a href="https://github.com/rust-lang/rust/issues/58465" target="_blank" title="https://github.com/rust-lang/rust/issues/58465">#58465</a>. This needs prioritization</p>



<a name="161960485"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960485" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960485">(Mar 28 2019 at 14:58)</a>:</h4>
<p>or we need to explicitly put it on a steering meeting agenda</p>



<a name="161960498"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960498" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960498">(Mar 28 2019 at 14:58)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> what do you think at this point? I'm not sure we're ever going to have time for <a href="https://github.com/rust-lang/rust/issues/58465" target="_blank" title="https://github.com/rust-lang/rust/issues/58465">#58465</a> at the thursday meetings, unless we allocate a WG-checkin slot to it on its own, and assign someone to drive discussion.</p>



<a name="161960591"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960591" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960591">(Mar 28 2019 at 14:59)</a>:</h4>
<p>next: "Incorporate RLS bug tracking into compiler team triage" <a href="https://github.com/rust-lang/rust/issues/58858" target="_blank" title="https://github.com/rust-lang/rust/issues/58858">#58858</a>. This was left nominated from when it was originally created but I actually think we can un-nominate it, unless I continue to fail to make any progress on it.</p>



<a name="161960592"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960592" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960592">(Mar 28 2019 at 14:59)</a>:</h4>
<p>I'm going to thus un-nominated <a href="https://github.com/rust-lang/rust/issues/58858" target="_blank" title="https://github.com/rust-lang/rust/issues/58858">#58858</a></p>



<a name="161960686"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960686" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960686">(Mar 28 2019 at 15:00)</a>:</h4>
<p><strong>finally</strong>: " Specific code layout can cause compiler panic with lto=true <a href="https://github.com/rust-lang/rust/issues/59137" target="_blank" title="https://github.com/rust-lang/rust/issues/59137">#59137</a>"</p>



<a name="161960707"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960707" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960707">(Mar 28 2019 at 15:00)</a>:</h4>
<p>didn't have time to look into that yet :/</p>



<a name="161960714"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960714" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960714">(Mar 28 2019 at 15:00)</a>:</h4>
<p>and, hah, that was another accidental nomination tag I forgot to remove</p>



<a name="161960729"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960729" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960729">(Mar 28 2019 at 15:00)</a>:</h4>
<p>that's okay <span class="user-mention" data-user-id="124287">@mw</span>, the nomination was left over from when I wanted a volunteer for it</p>



<a name="161960763"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960763" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960763">(Mar 28 2019 at 15:01)</a>:</h4>
<p>we ... we actually "got through" everything</p>



<a name="161960779"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960779" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960779">(Mar 28 2019 at 15:01)</a>:</h4>
<p>perhaps only in a superficial manner</p>



<a name="161960792"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960792" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960792">(Mar 28 2019 at 15:01)</a>:</h4>
<p>but I like to stress the <strong>super</strong> in "superficial"</p>



<a name="161960824"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960824" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960824">(Mar 28 2019 at 15:01)</a>:</h4>
<p>Okay then, thanks to everyone in <span class="user-group-mention" data-user-group-id="897">@T-compiler/meeting</span> for attending!</p>



<a name="161960889"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161960889" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161960889">(Mar 28 2019 at 15:02)</a>:</h4>
<p>thanks for driving, <span class="user-mention" data-user-id="116083">@pnkfelix</span> !</p>



<a name="161961002"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961002" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961002">(Mar 28 2019 at 15:03)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> <span class="user-mention" data-user-id="116009">@nikomatsakis</span>  btw... re. the <code>Box</code> magic thing... is this something to discuss at T-Lang? If we can avoid putting more problems in front of de-magickifiying <code>Box</code> that would be nice.</p>



<a name="161961010"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961010" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961010">(Mar 28 2019 at 15:03)</a>:</h4>
<p>Should I actually unassign <span class="user-mention" data-user-id="119009">@eddyb</span> from the review of PRs <a href="https://github.com/rust-lang/rust/issues/58846" target="_blank" title="https://github.com/rust-lang/rust/issues/58846">#58846</a> and <a href="https://github.com/rust-lang/rust/issues/56636" target="_blank" title="https://github.com/rust-lang/rust/issues/56636">#56636</a> ?</p>



<a name="161961035"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961035" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961035">(Mar 28 2019 at 15:03)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> not until you assign someone else</p>



<a name="161961100"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961100" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961100">(Mar 28 2019 at 15:04)</a>:</h4>
<p>I've grabbed 58846</p>



<a name="161961110"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961110" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961110">(Mar 28 2019 at 15:04)</a>:</h4>
<p>thanks <span class="user-mention" data-user-id="124288">@oli</span></p>



<a name="161961131"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961131" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961131">(Mar 28 2019 at 15:04)</a>:</h4>
<p><span class="user-mention" data-user-id="126931">@centril</span> let me make sure I understand the logic here</p>



<a name="161961153"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961153" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961153">(Mar 28 2019 at 15:04)</a>:</h4>
<p>if I decide I don't have time to review something, I can unassign myself without finding someone else</p>



<a name="161961228"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961228" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961228">(Mar 28 2019 at 15:05)</a>:</h4>
<p>I do think that the correct protocol here would be to first <em>ping</em> <span class="user-mention" data-user-id="119009">@eddyb</span>  (or any other assigned reviewer) before just blindly unassigning them.</p>



<a name="161961234"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961234" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961234">(Mar 28 2019 at 15:05)</a>:</h4>
<blockquote>
<p>I can unassign myself without finding someone else</p>
</blockquote>
<p>Ideally not... at least the team should be pinged or so... All PRs should have reviewers</p>



<a name="161961309"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961309" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961309">(Mar 28 2019 at 15:06)</a>:</h4>
<p>Yes, pinging is right</p>



<a name="161961365"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961365" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961365">(Mar 28 2019 at 15:06)</a>:</h4>
<p>I agree that ideally, one would <em>delegate</em> a review to someone else rather than just ceding responsibility entirely.</p>



<a name="161961372"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961372" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961372">(Mar 28 2019 at 15:06)</a>:</h4>
<p>I think reassigning is preferable to pinging tho it much time has gone by since it is usually faster</p>



<a name="161961393"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961393" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961393">(Mar 28 2019 at 15:07)</a>:</h4>
<p>but finding someone to take on a review is itself a task</p>



<a name="161961407"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961407" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961407">(Mar 28 2019 at 15:07)</a>:</h4>
<p>and so I'm claiming that in the general case, we cannot avoid people unassigning themselves</p>



<a name="161961420"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961420" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961420">(Mar 28 2019 at 15:07)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> we could make it a thing to unassign yourself and let T-release find a reviewer</p>



<a name="161961491"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961491" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961491">(Mar 28 2019 at 15:08)</a>:</h4>
<p>I guess all I'm saying is that there may be a process breakdown here</p>



<a name="161961501"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961501" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961501">(Mar 28 2019 at 15:08)</a>:</h4>
<p>what I would prefer not to happen is for a PR to be unassigned for a long time without anything happening to it</p>



<a name="161961504"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961504" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961504">(Mar 28 2019 at 15:08)</a>:</h4>
<p>since I tend to assume that if a PR has an assignee, it <em>is</em> getting dealt wth</p>



<a name="161961538"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961538" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961538">(Mar 28 2019 at 15:08)</a>:</h4>
<p>and so I'll skim the PR list and look for ones that have <em>no</em> assignee</p>



<a name="161961563"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961563" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961563">(Mar 28 2019 at 15:09)</a>:</h4>
<p>to try to determine what needs attention</p>



<a name="161961588"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961588" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961588">(Mar 28 2019 at 15:09)</a>:</h4>
<p>but this process will break down if PR's are artifically holding on to their assignees, right?</p>



<a name="161961603"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961603" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961603">(Mar 28 2019 at 15:09)</a>:</h4>
<p>btw I am hard to reach because of the choice of chat systems is horrible for me</p>



<a name="161961609"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961609" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961609">(Mar 28 2019 at 15:09)</a>:</h4>
<p>(I do agree that it would <em>also</em> be a break down in process for PR's to go unassigned for long periods of time)</p>



<a name="161961618"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961618" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961618">(Mar 28 2019 at 15:09)</a>:</h4>
<p><span class="user-mention" data-user-id="119009">@eddyb</span> I understand that problem</p>



<a name="161961692"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961692" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961692">(Mar 28 2019 at 15:10)</a>:</h4>
<p>IRC channels/PM &gt; Discord PMs &gt; Zulip PMs &gt; Discord channels (some of which I avoid because I still haven't processed the backlog) &gt; Zulip topics</p>



<a name="161961729"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961729" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961729">(Mar 28 2019 at 15:10)</a>:</h4>
<p>where do Zulip topics rank compared to Github notifications though? <span aria-label="smiley" class="emoji emoji-1f603" role="img" title="smiley">:smiley:</span></p>



<a name="161961730"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961730" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961730">(Mar 28 2019 at 15:10)</a>:</h4>
<p>as for GH notification I still have a backlog but try to often go through the last N pings, using <a href="http://octobox.io" target="_blank" title="http://octobox.io">octobox.io</a></p>



<a name="161961759"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961759" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961759">(Mar 28 2019 at 15:11)</a>:</h4>
<p>well I can't see GH notification context without clicking on them</p>



<a name="161961765"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961765" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961765">(Mar 28 2019 at 15:11)</a>:</h4>
<p>I cannot hope to keep up with Discord myself</p>



<a name="161961782"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961782" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961782">(Mar 28 2019 at 15:11)</a>:</h4>
<p>srsly talk to me in PM if you need me personally</p>



<a name="161961796"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961796" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961796">(Mar 28 2019 at 15:11)</a>:</h4>
<p>(I still find the Discord mention system to be inscrutable.)</p>



<a name="161961809"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961809" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961809">(Mar 28 2019 at 15:11)</a>:</h4>
<p>you can use Discord's search instead</p>



<a name="161961811"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961811" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961811">(Mar 28 2019 at 15:11)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span>  I think that 1) if unassigning without assigning someone else is a thing, then we need a T-compiler/T-release process for reassignment. 2) If folks cannot review a PR they should either a) unassign themselves, b) reassign someone else.</p>



<a name="161961817"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961817" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961817">(Mar 28 2019 at 15:11)</a>:</h4>
<p>and search for mentions: or something</p>



<a name="161961904"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961904" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961904">(Mar 28 2019 at 15:12)</a>:</h4>
<p>also highfive is assigning me a ridiculous amount of things, most of which are irrelevant for my particular areas of the compiler I care about or can honestly review</p>



<a name="161961920"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961920" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961920">(Mar 28 2019 at 15:12)</a>:</h4>
<p>I was filing an issue about that earlier</p>



<a name="161961941"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961941" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961941">(Mar 28 2019 at 15:12)</a>:</h4>
<p>highfive shouldn't be assigning Niko and <span class="user-mention" data-user-id="119009">@eddyb</span>  all the time</p>



<a name="161961948"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961948" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961948">(Mar 28 2019 at 15:12)</a>:</h4>
<blockquote>
<p>1) if unassigning without assigning someone else is a thing, then we need a T-compiler/T-release process for reassignment. </p>
</blockquote>
<p>Hmm. true, I do visit the P-high issues each week looking in part for the unassigned cases</p>



<a name="161961975"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961975" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961975">(Mar 28 2019 at 15:13)</a>:</h4>
<p>arguably I should also be visiting the PR's</p>



<a name="161961993"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161961993" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161961993">(Mar 28 2019 at 15:13)</a>:</h4>
<p>but those aren't always explicitly marked with T-compiler, right?</p>



<a name="161962006"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962006" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962006">(Mar 28 2019 at 15:13)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span>  PRs? no.</p>



<a name="161962093"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962093" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962093">(Mar 28 2019 at 15:14)</a>:</h4>
<p>yeah. So it would not be trivial for me to include the PRs in the weekly triage right now</p>



<a name="161962117"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962117" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962117">(Mar 28 2019 at 15:14)</a>:</h4>
<p>it's incredible how many bad repercussions shipping Rust 2018 + taking work in December had on my ability to stay on top of things</p>



<a name="161962122"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962122" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962122">(Mar 28 2019 at 15:14)</a>:</h4>
<p>but I suppose if someone, before unassigning themself, did have to at least tag the team who should find the next reviewer</p>



<a name="161962137"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962137" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962137">(Mar 28 2019 at 15:14)</a>:</h4>
<p>then that would help there, right <span class="user-mention" data-user-id="126931">@centril</span> ?</p>



<a name="161962152"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962152" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962152">(Mar 28 2019 at 15:14)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> <a href="https://github.com/rust-lang/rust/pulls?q=is%3Aopen+is%3Apr+no%3Aassignee" target="_blank" title="https://github.com/rust-lang/rust/pulls?q=is%3Aopen+is%3Apr+no%3Aassignee">https://github.com/rust-lang/rust/pulls?q=is%3Aopen+is%3Apr+no%3Aassignee</a> the list is pretty small</p>



<a name="161962210"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962210" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962210">(Mar 28 2019 at 15:15)</a>:</h4>
<p>yeah assigning the team would be good</p>



<a name="161962213"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962213" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962213">(Mar 28 2019 at 15:15)</a>:</h4>
<p>anyway, small announcement, I got a 1440p 24" monitor this week, and will try to more aggressively go through things. I wish chrome had tree-style tabs or firefox was easy to swap all the state to...</p>



<a name="161962226"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962226" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962226">(Mar 28 2019 at 15:15)</a>:</h4>
<p>or fallback to t-release if no team is there</p>



<a name="161962243"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962243" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962243">(Mar 28 2019 at 15:15)</a>:</h4>
<p>the Zulip app is worse than ever, perf-wise, though, jeeez</p>



<a name="161962259"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962259" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962259">(Mar 28 2019 at 15:15)</a>:</h4>
<p><span class="user-mention" data-user-id="119009">@eddyb</span>  did you kill your laptop yet?</p>



<a name="161962267"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962267" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962267">(Mar 28 2019 at 15:16)</a>:</h4>
<blockquote>
<p>the Zulip app is worse than ever, perf-wise, though, jeeez</p>
</blockquote>
<p>on the mobile device? Or on the computer?</p>



<a name="161962320"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962320" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962320">(Mar 28 2019 at 15:16)</a>:</h4>
<p>on my laptop. on my phone it's much worse</p>



<a name="161962345"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962345" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962345">(Mar 28 2019 at 15:16)</a>:</h4>
<p>/me must have stockholm syndrome when it comes to Zulip</p>



<a name="161962351"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962351" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962351">(Mar 28 2019 at 15:16)</a>:</h4>
<p>the mobile app may be a phone health risk, more so than mobile games</p>



<a name="161962391"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962391" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962391">(Mar 28 2019 at 15:16)</a>:</h4>
<p>I like Zulip's ideas but the UI and UX are depressing</p>



<a name="161962443"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962443" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962443">(Mar 28 2019 at 15:17)</a>:</h4>
<blockquote>
<p><span class="user-mention silent" data-user-id="116083">pnkfelix</span> <a href="https://github.com/rust-lang/rust/pulls?q=is%3Aopen+is%3Apr+no%3Aassignee" target="_blank" title="https://github.com/rust-lang/rust/pulls?q=is%3Aopen+is%3Apr+no%3Aassignee">https://github.com/rust-lang/rust/pulls?q=is%3Aopen+is%3Apr+no%3Aassignee</a> the list is pretty small</p>
</blockquote>
<p>let me try adding this to the list of weekly triage items, see if its worth including in that parallel topic</p>



<a name="161962466"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962466" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962466">(Mar 28 2019 at 15:17)</a>:</h4>
<p>oh hmm, Zulip looks way less bad when tall</p>



<a name="161962468"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962468" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962468">(Mar 28 2019 at 15:17)</a>:</h4>
<p>if the list grows significnatly in the future, then that will be a sign that we need more pro-active T-tagging on it</p>



<a name="161962526"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962526" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962526">(Mar 28 2019 at 15:18)</a>:</h4>
<p>but no chat app deserves a full column of my tiled layout</p>



<a name="161962539"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962539" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962539">(Mar 28 2019 at 15:18)</a>:</h4>
<p>At least zulip can deal with being squished sideways</p>



<a name="161962544"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962544" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962544">(Mar 28 2019 at 15:18)</a>:</h4>
<p>Discord wont let me</p>



<a name="161962562"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962562" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962562">(Mar 28 2019 at 15:18)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> so... re. <code>Box</code> &amp; magic...  discuss on T-Lang meeting?</p>



<a name="161962570"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962570" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962570">(Mar 28 2019 at 15:18)</a>:</h4>
<p>What I would like most is to understand the issue</p>



<a name="161962599"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962599" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962599">(Mar 28 2019 at 15:19)</a>:</h4>
<p>what the magic consists of exactly and document it well on a GH issue</p>



<a name="161962605"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962605" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962605">(Mar 28 2019 at 15:19)</a>:</h4>
<p>oooh I can make Zulip taller at the expense of IRC &amp; DIscord</p>



<a name="161962624"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962624" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962624">(Mar 28 2019 at 15:19)</a>:</h4>
<p><span class="user-mention" data-user-id="126931">@centril</span> <code>DerefMove</code> but without an <code>impl</code> opt-in</p>



<a name="161962635"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962635" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962635">(Mar 28 2019 at 15:19)</a>:</h4>
<blockquote>
<p><span class="user-mention silent" data-user-id="116083">pnkfelix</span> so... re. <code>Box</code> &amp; magic...  discuss on T-Lang meeting?</p>
</blockquote>
<p>If you want to add it as an item, I guess you can. I think most people who care about the issue tend to think that the solution is to factor the magic into its own <code>DerefMove</code> trait</p>



<a name="161962647"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962647" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962647">(Mar 28 2019 at 15:19)</a>:</h4>
<p>the semantics are what I want for <code>DerefMove</code></p>



<a name="161962668"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962668" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962668">(Mar 28 2019 at 15:19)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> is <code>DerefMove</code> the only thing?</p>



<a name="161962676"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962676" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962676">(Mar 28 2019 at 15:20)</a>:</h4>
<p>or is there additional magic now?</p>



<a name="161962748"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962748" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962748">(Mar 28 2019 at 15:20)</a>:</h4>
<p>(wrt. <a href="https://github.com/rust-lang/rust/pull/58021" target="_blank" title="https://github.com/rust-lang/rust/pull/58021">https://github.com/rust-lang/rust/pull/58021</a>)</p>



<a name="161962774"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962774" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962774">(Mar 28 2019 at 15:20)</a>:</h4>
<p>regarding <a href="https://github.com/rust-lang/rust/issues/58021" target="_blank" title="https://github.com/rust-lang/rust/issues/58021">#58021</a>, I have no idea</p>



<a name="161962806"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962806" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962806">(Mar 28 2019 at 15:20)</a>:</h4>
<p>I still haven't processed what the heck happened there. Thus my desire to make a regression test.</p>



<a name="161962816"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962816" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962816">(Mar 28 2019 at 15:21)</a>:</h4>
<p>The destructor is magical.</p>



<a name="161962857"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962857" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962857">(Mar 28 2019 at 15:21)</a>:</h4>
<p>But perhaps it needs to be for any <code>DerefMove</code>,  not sure.</p>



<a name="161962878"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962878" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962878">(Mar 28 2019 at 15:21)</a>:</h4>
<p><span class="user-mention" data-user-id="123856">@Vadim Petrochenkov</span> I think the right solution is what <span class="user-mention" data-user-id="126804">@Ariel Ben-Yehuda</span> came up with, which is that <code>DerefMove</code> opts into drop glue being <code>drop_in_place(&amp;mut *x); Drop::drop(&amp;mut x);</code></p>



<a name="161962918"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962918" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962918">(Mar 28 2019 at 15:22)</a>:</h4>
<p>I suppose that needs to make <code>Drop</code> an <code>unsafe impl</code></p>



<a name="161962974"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962974" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962974">(Mar 28 2019 at 15:22)</a>:</h4>
<p>Support for <code>box</code> patterns is magical.<br>
Also seems a part of <code>DerefMove</code>.</p>



<a name="161962987"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161962987" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161962987">(Mar 28 2019 at 15:22)</a>:</h4>
<p>/me needs to go AFK, but feel free to carry on chatting. <span class="user-mention" data-user-id="126931">@centril</span> : double check whether niko will be at the meeting tonight. If not, then I wouldn't try to do the <code>Box</code> Q at tonight's meeting, unless <span class="user-mention" data-user-id="119009">@eddyb</span> <strong>is</strong> attending.</p>



<a name="161963011"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963011" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963011">(Mar 28 2019 at 15:23)</a>:</h4>
<p><code>Box</code>s ABI was also very special, not sure about the current status.</p>



<a name="161963029"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963029" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963029">(Mar 28 2019 at 15:23)</a>:</h4>
<p><span class="user-mention" data-user-id="119009">@eddyb</span>  care to join the meeting?</p>



<a name="161963047"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963047" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963047">(Mar 28 2019 at 15:23)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span>  so... I forget, are you attending the T-Lang meeting today?</p>



<a name="161963056"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963056" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963056">(Mar 28 2019 at 15:23)</a>:</h4>
<p>ah, patterns, well, I think we should maybe consider checking the MIR via borrowck instead of having a separate pattern checker...</p>



<a name="161963091"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963091" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963091">(Mar 28 2019 at 15:24)</a>:</h4>
<p>(<code>box</code> patterns are unstable)</p>



<a name="161963133"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963133" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963133">(Mar 28 2019 at 15:24)</a>:</h4>
<p>i.e. check that the <code>if-else</code> chains or <code>switch</code> w/e generated by pattern lowering are exhaustive</p>



<a name="161963184"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963184" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963184">(Mar 28 2019 at 15:24)</a>:</h4>
<p>not sure I can join voice/video meetings, given my new office situation</p>



<a name="161963205"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963205" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963205">(Mar 28 2019 at 15:24)</a>:</h4>
<p>also, is the DST hell over?</p>



<a name="161963226"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963226" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963226">(Mar 28 2019 at 15:25)</a>:</h4>
<p><span class="user-mention" data-user-id="119009">@eddyb</span> no, not until next week</p>



<a name="161963236"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963236" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963236">(Mar 28 2019 at 15:25)</a>:</h4>
<p>because I think the meeting is after the time I have  to leave to catch the subway during this time</p>



<a name="161963247"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963247" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963247">(Mar 28 2019 at 15:25)</a>:</h4>
<p>(which I was mistaken about up until last monday)</p>



<a name="161963248"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963248" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963248">(Mar 28 2019 at 15:25)</a>:</h4>
<p>so was I pinged only for <a href="https://github.com/rust-lang/rust/issues/58021" target="_blank" title="https://github.com/rust-lang/rust/issues/58021">#58021</a>?</p>



<a name="161963268"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963268" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963268">(Mar 28 2019 at 15:25)</a>:</h4>
<p><span class="user-mention" data-user-id="119009">@eddyb</span> there were some PR's in your review queue that we also discussed</p>



<a name="161963324"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963324" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963324">(Mar 28 2019 at 15:26)</a>:</h4>
<p>right, sorry about that</p>



<a name="161963325"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963325" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963325">(Mar 28 2019 at 15:26)</a>:</h4>
<p>in terms of whether to delegate the reviews to other people</p>



<a name="161963342"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963342" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963342">(Mar 28 2019 at 15:26)</a>:</h4>
<p>people need to contaact me personally, GH pings will not guarantee I will see it</p>



<a name="161963344"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963344" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963344">(Mar 28 2019 at 15:26)</a>:</h4>
<p>(I don't think you need to apologize.)</p>



<a name="161963359"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963359" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963359">(Mar 28 2019 at 15:26)</a>:</h4>
<p>good idea to ask before reassigning, some things I can review on the spot</p>



<a name="161963360"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963360" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963360">(Mar 28 2019 at 15:26)</a>:</h4>
<p>(we know you've juggling a lot)</p>



<a name="161963366"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963366" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963366">(Mar 28 2019 at 15:26)</a>:</h4>
<p>again, much easier since this week</p>



<a name="161963387"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963387" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963387">(Mar 28 2019 at 15:27)</a>:</h4>
<p>it's less being busy and more a cascading failure to keep up :P</p>



<a name="161963431"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963431" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963431">(Mar 28 2019 at 15:27)</a>:</h4>
<p>like leaving one minute late and being an hour late by the time you reach wherever you want to get</p>



<a name="161963812"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963812" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963812">(Mar 28 2019 at 15:31)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> <a href="https://play.rust-lang.org/?version=nightly&amp;mode=debug&amp;edition=2018&amp;gist=dae27f4169c6e5cf24c73dd763984055" target="_blank" title="https://play.rust-lang.org/?version=nightly&amp;mode=debug&amp;edition=2018&amp;gist=dae27f4169c6e5cf24c73dd763984055">https://play.rust-lang.org/?version=nightly&amp;mode=debug&amp;edition=2018&amp;gist=dae27f4169c6e5cf24c73dd763984055</a></p>



<a name="161963835"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963835" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963835">(Mar 28 2019 at 15:31)</a>:</h4>
<p>5 happens before 3</p>



<a name="161963843"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161963843" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161963843">(Mar 28 2019 at 15:31)</a>:</h4>
<p>thus making it observable</p>



<a name="161964191"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964191" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964191">(Mar 28 2019 at 15:34)</a>:</h4>
<p>hehehe I just realized I can give Zulip more vertical screenspace</p>



<a name="161964276"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964276" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964276">(Mar 28 2019 at 15:35)</a>:</h4>
<blockquote>
<p>5 happens before 3</p>
</blockquote>
<p>hmm isn't that what's supposed to happen there? Is that actually an example of weirdness...?</p>



<a name="161964282"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964282" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964282">(Mar 28 2019 at 15:35)</a>:</h4>
<p>since you used a <code>_</code> pattern in that arm that causes <code>dbg!(5)</code> ?</p>



<a name="161964390"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964390" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964390">(Mar 28 2019 at 15:36)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span>  changing it to <code>b =&gt; { dbg!(5); }</code> makes no difference</p>



<a name="161964437"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964437" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964437">(Mar 28 2019 at 15:37)</a>:</h4>
<p>(or <code>b =&gt; { dbg!(b); }</code>)</p>



<a name="161964438"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964438" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964438">(Mar 28 2019 at 15:37)</a>:</h4>
<p>I'm still not convinced this is what matters</p>



<a name="161964467"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964467" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964467">(Mar 28 2019 at 15:37)</a>:</h4>
<p>(i.e., <code>b</code> <em>should</em> be dropped <code>5</code> is printed...)</p>



<a name="161964537"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964537" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964537">(Mar 28 2019 at 15:38)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> not sure I get what you mean... this is just demonstrating the drop order that ariel noted</p>



<a name="161964543"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964543" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964543">(Mar 28 2019 at 15:38)</a>:</h4>
<p>but you are correct that I was wrong to think that the  <code>_</code> pattern mattered there</p>



<a name="161964596"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964596" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964596">(Mar 28 2019 at 15:38)</a>:</h4>
<p>my claim is that the drop order you are describing is what we would want to adhere to, even with the changes ariel wants</p>



<a name="161964610"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964610" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964610">(Mar 28 2019 at 15:38)</a>:</h4>
<p><a href="/user_uploads/4715/TkG4MkZKV5yOUp587KPKhqmd/pasted_image.png" target="_blank" title="pasted_image.png">pasted image</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/TkG4MkZKV5yOUp587KPKhqmd/pasted_image.png" target="_blank" title="pasted image"><img src="/user_uploads/4715/TkG4MkZKV5yOUp587KPKhqmd/pasted_image.png"></a></div>



<a name="161964620"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964620" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> eddyb <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964620">(Mar 28 2019 at 15:39)</a>:</h4>
<p>this seems more workable</p>



<a name="161964648"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964648" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964648">(Mar 28 2019 at 15:39)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span>  oh... well I don't disagree with that</p>



<a name="161964684"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964684" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964684">(Mar 28 2019 at 15:39)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> I mostly thought it would be good to proactively discuss and affirm our view with the whole language team</p>



<a name="161964801"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964801" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964801">(Mar 28 2019 at 15:40)</a>:</h4>
<p>okay ... but this doesn't directly show the duplicated storage-dead's that <span class="user-mention" data-user-id="126804">@Ariel Ben-Yehuda</span> described.</p>



<a name="161964835"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964835" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964835">(Mar 28 2019 at 15:41)</a>:</h4>
<p>but ooh maybe we can get miri to complain about them!</p>



<a name="161964855"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964855" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964855">(Mar 28 2019 at 15:41)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span>  yeah I only went for drop order since that's easiest to show ;)</p>



<a name="161964874"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161964874" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161964874">(Mar 28 2019 at 15:42)</a>:</h4>
<p>ill nominate then</p>



<a name="161965035"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161965035" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161965035">(Mar 28 2019 at 15:43)</a>:</h4>
<p>well if you nominate I'm not sure I'm going to be able to present tonight</p>



<a name="161965123"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161965123" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161965123">(Mar 28 2019 at 15:44)</a>:</h4>
<p>someone will need to drive that discussion but I doubt it will be me, at least not this week (DST hell)</p>



<a name="161965177"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161965177" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161965177">(Mar 28 2019 at 15:44)</a>:</h4>
<p><span class="user-mention" data-user-id="116083">@pnkfelix</span> worst case we delay till next week</p>



<a name="161965185"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161965185" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161965185">(Mar 28 2019 at 15:45)</a>:</h4>
<p>k</p>



<a name="161983822"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161983822" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161983822">(Mar 28 2019 at 19:16)</a>:</h4>
<blockquote>
<p>I guess that the concerns <span class="user-mention silent" data-user-id="123586">nagisa</span> raised were mostly kind of "memory usage is too high, let's not regress, even a bit"?</p>
</blockquote>
<p>FWIW I managed to build rustc on a 4G 64-bit VM, so there’s that. I’m significantly less concerned about our memory usage now.</p>



<a name="161983847"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/161983847" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nagisa <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#161983847">(Mar 28 2019 at 19:16)</a>:</h4>
<p>That was FreeBSD btw.</p>



<a name="162005867"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/162005867" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tatsuyuki Ishi <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#162005867">(Mar 29 2019 at 00:25)</a>:</h4>
<p>Regarding the test, I originally thought of using miri, because it can test memory semantics apart from double free which the allocator wouldn't care otherwise. But for a "regression" test it could be written without miri. I didn't bother with the miri test because I was short on time and didn't know how miri based tests work.</p>



<a name="162005954"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/162005954" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Tatsuyuki Ishi <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#162005954">(Mar 29 2019 at 00:27)</a>:</h4>
<p>(that was about <a href="https://github.com/rust-lang/rust/issues/58021" target="_blank" title="https://github.com/rust-lang/rust/issues/58021">#58021</a>)</p>



<a name="162027837"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/162027837" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#162027837">(Mar 29 2019 at 08:40)</a>:</h4>
<p><span class="user-mention" data-user-id="117366">@Tatsuyuki Ishi</span> ah, I didn't look properly at <em>where</em> this change was being applied before. I had thought it was some <code>fn map</code> in <code>libstd</code>, not <code>libsyntax</code></p>



<a name="162027841"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-03-28%20%2354818/near/162027841" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> pnkfelix <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-03-28.20.2354818.html#162027841">(Mar 29 2019 at 08:40)</a>:</h4>
<p>i am far far far less concerned about this now.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>